Fix: re-propagate interrupt causes in sendTurnForThread catchCause handler#1155
Draft
cursor[bot] wants to merge 1 commit intocodething/648ca884-claudefrom
Draft
Fix: re-propagate interrupt causes in sendTurnForThread catchCause handler#1155cursor[bot] wants to merge 1 commit intocodething/648ca884-claudefrom
cursor[bot] wants to merge 1 commit intocodething/648ca884-claudefrom
Conversation
…ndler The inner Effect.catchCause around sendTurnForThread was unconditionally catching all causes, including interrupts. During shutdown or fiber cancellation, this would create a spurious provider.turn.start.failed activity and swallow the interrupt signal before the outer processDomainEventSafely handler could re-propagate it. Add a Cause.hasInterruptsOnly check (matching the pattern used elsewhere in the codebase) to re-fail with the cause when it is interrupt-only. Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
github-actions
bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inner
Effect.catchCausewrapper aroundsendTurnForThreadinProviderCommandReactor.tsunconditionally caught all causes, including interrupts. During shutdown or fiber cancellation, this would:provider.turn.start.failedactivityprocessDomainEventSafelyhandler could re-propagate itFix
Added a
Cause.hasInterruptsOnly(cause)check in the inner handler (matching the pattern used inprocessDomainEventSafelyand elsewhere in the codebase) to re-fail with the cause when it is interrupt-only, allowing proper interrupt propagation.Note
Re-propagate interrupt causes in
sendTurnForThreadcatchCause handlerIn ProviderCommandReactor.ts, the
catchCausehandler for provider turn start now checksCause.hasInterruptsOnly(cause)and re-fails withEffect.failCause(cause)instead of recording aprovider.turn.start.failedactivity. Non-interrupt failures continue to produce the failure activity as before.Macroscope summarized ae48a85.